ContactParser. Program code was Updated#20
Open
KnightDanila wants to merge 5 commits intodemmy:masterfrom
qlynn:KnightDanila
Open
ContactParser. Program code was Updated#20KnightDanila wants to merge 5 commits intodemmy:masterfrom qlynn:KnightDanila
KnightDanila wants to merge 5 commits intodemmy:masterfrom
qlynn:KnightDanila
Conversation
update from origin
update from origin
- I didn't did it, because someone other will do it ( I think so :) )
2) if (item.IsChosen == true) and if(item.IsChosen)
- I did it in all forms in all similar places :)
3) Names with form1, Also, such names are very bad to read: form2OrigHight, gridView1
- Renamed names which was like this
4) Inconsistent naming: underscores with CamelCase. Use CamelCase only.
- I Did this all (I think so :) )
5) Such strings should be put in resources
(
MessageBox.Show("Ошибка: Невозможно считать файл с диска!!!");
Form1_TextField_FilePath.Text = "Путь к файлу...";
openFileDialog1.Filter = "txt files (*.txt)|*.txt";
)
- Put in resources some message and constant strings
6) No commented garbage code in code of release
- I Cleaned it
7) Incorrect file structure
- I did it in forms Level - Maybe it not a good method, but program is working :)
8)
- Added some small code corrections (in forms level)
Egoshkin Danila
KnightDanila
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't did it, because someone other will do it ( I think so :) )
I did it in all forms in all similar places :)
Renamed names which was like this
I Did this all (I think so :) )
(
MessageBox.Show("Ошибка: Невозможно считать файл с диска!!!");
Form1_TextField_FilePath.Text = "Путь к файлу...";
openFileDialog1.Filter = "txt files (.txt)|.txt";
)
Put in resources some message and constant strings
I Cleaned it
I did it in forms Level - Maybe it not a good method, but program is working :)
Added some small code corrections (in forms level)