fixes for max short test #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
force-pushed
the
dpaiton/fix-max-short-tests
branch
2 times, most recently
from
6e4d09b to
8f7f5a3
Compare
sentilesdal
force-pushed
the
dpaiton/max-short-test
branch
from
36c400e to
1f2eb62
Compare
sentilesdal
force-pushed
the
dpaiton/fix-max-short-tests
branch
from
33c1a9b to
201b048
Compare
sentilesdal
approved these changes
Jan 22, 2025
Contributor
sentilesdal
left a comment
sentilesdal
left a comment
There was a problem hiding this comment.
went through this PR in detail IRL with @dpaiton. Looks good, nothing broken, better than it was before. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary contributions in this PR are:
z_min + max(zeta, 0) + e/ctoz_min + max(zeta, e/c, 0). This update is justified because the checks are performed independently, and thus the reserves do not need to account for share reserves plus exposure. Just whichever is larger.Other changes:
FixedPoint::<I256>instead ofFixedPoint::<U256>. This cleaned up the logic in the max short functions.fuzz_sol_calculate_max_longgets a tolerance -- it was intermittently failing in PRs. Later we should fix this, as requested in Max long & short failures in fuzz testing #136