wildcard replace ports #86
Open
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamex
requested review from
jalextowle,
jrhea,
ryangoree and
slundqui
as code owners
wakamex
changed the title
wakamex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets you reference any variable from env/env.ports in another config file in the env folder
after the .env is generated, we replace port names like
UI_RPC_URL=http://localhost:ETH_PORT.for now, that's the only one that makes sense to do this with.
do NOT replace
RPC_URI=http://ethereum:8545with your local ETH_PORT, as that is for inside-docker networking. I've added a lengthy comment to remind me of next time I forget this.