-
Notifications
You must be signed in to change notification settings - Fork 0
2 - document that rebasing token share quantities must be equivalent to their wrapped quantities #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcclurejt
wants to merge
2
commits into
main
Choose a base branch
from
mcclurejt/fix/wrapped-amounts-and-vault-shares-amounts-equal-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2 - document that rebasing token share quantities must be equivalent to their wrapped quantities #47
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,6 +82,55 @@ source .env && \ | |
| forge script script/DeployEverlongStrategy.s.sol --rpc-url 0.0.0.0:8545 --broadcast | ||
| ``` | ||
|
|
||
| #### Options | ||
|
|
||
| ##### `AS_BASE=<true>` | ||
|
|
||
| Specifies whether to use hyperdrive's base token or vault shares token when | ||
| transacting with hyperdrive. | ||
|
|
||
| | :warning: WARNING | | ||
| | :----------------------------------------------------------------- | | ||
| | When `IS_WRAPPED` is set, `AS_BASE` must be false (or left empty). | | ||
|
|
||
| ##### `IS_WRAPPED=<true>` | ||
|
|
||
| Wrap the token used to transact with hyperdrive. If the hyperdrive vault shares | ||
| token is a rebasing token, `IS_WRAPPED` must be set to true since Yearn vaults | ||
| explicitly do not support rebasing tokens. | ||
|
|
||
| | :exclamation: IMPORTANT | | ||
| | :---------------------------------------------------------------------- | | ||
| | The address for the wrapped asset must be set via the `ASSET` parameter | | ||
|
|
||
| | :exclamation: IMPORTANT | | ||
| | :------------------------------------------------------------------------------------------------------------- | | ||
| | Only rebasing tokens whos "share" token quantities equal the wrapped token quantities can be used (EX: StETH). | | ||
|
|
||
| ##### `ASSET=<address>` | ||
|
|
||
| Set the address for the strategy asset. This should only be set when | ||
| `IS_WRAPPED=true`. | ||
|
|
||
| When `IS_WRAPPED=false`, the strategy asset is the hyperdrive's base token or | ||
| vault shares token depending on the value of `AS_BASE`. | ||
|
|
||
| ##### `PROFIT_MAX_UNLOCK=<seconds>` | ||
|
|
||
| Period in seconds to unlock profit over for the strategy. | ||
|
|
||
| If deposits/redemptions to the strategy are limited to approved vaults, this | ||
| can be set to zero for faster yield accrual by the vaults. | ||
|
|
||
| If deposits/redemptions to the strategy are not permissioned, this should be set | ||
| to at least the yield accrual interval of hyperdrive (typically 1 day). | ||
|
Comment on lines
+125
to
+126
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought in practice you'll always use a vault? Because, otherwise your assumptions that the strategy's idle is close to 0 does not hold, for example. |
||
|
|
||
| ##### `KEEPER_CONTRACT_NAME=<string>` | ||
|
|
||
| Name of the keeper contract to use for tending and reporting. | ||
|
|
||
| By default, this is the most recently deployed keeper contract on the chain. | ||
|
|
||
| ### Deploy a `Vault` | ||
|
|
||
| ```sh | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whose