Skip to content
This repository was archived by the owner on Oct 10, 2021. It is now read-only.

Conversation

@sylvaincombes
Copy link

Use @vvo patch of tap-finished : see #223

@sylvaincombes
Copy link
Author

Ok I don' t understand why tests fails this time, I closed my previous pull request #233 since I don't know enough tape and zuul to be able to contribute + time factor.

This time I went very simple : I only change the package.json to require the patched version of tap-finished of @vvo

Do you have any idea on what's going on ?

@vvo
Copy link
Collaborator

vvo commented Sep 21, 2015

Yes its failing because tests cannot run in a PR (encrypted environment variables for saucelabs tests being not available)

This should work but its adding a tarball dep, I would really want to get the PR merged in tap-finished.

Also I am no more testing on IE6-7 that's why this is not high priority for me. I would advise you to use a fork of zuul for the time being. Until we make tap-finished PR merged (but I will not spend time on it..)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants