Open
Conversation
…djust scrollview offset with the keyboard.
Owner
|
Thanks for your PR that I could test. The behavior does not match the initial expected behavior. If a field is already in view when entering edit mode, no scrolling should occur. With your implementation, as soon as you tap on a field, it immediately jumps right above the keyboard, which is annoying from a user point of view. This is also not perfectly consistent, as this offset can be changed afterwards when the user scrolls:
Could you please recall me what your exact issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using scrollRectToVisible:animated: seems to cause some problems to adjust scrollview offset with the keyboard. Could this solution be suitable?