chore: remove deprecated deserialize_document_store_in_init_params_in… #10454
+2
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place This function was deprecated in 2.23.0 and is no longer used internally. Removed the function, its exports, its tests, and the deprecation release note.
|
@Amanbig is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
|
|
github-actions
bot
added
topic:tests
type:documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore!: remove deprecated deserialize_document_store_in_init_params_inplace (closes #10443)
The helper function
deserialize_document_store_in_init_params_inplacewas deprecated in v2.23.0 and is no longer used internally.This PR removes the function and all remaining references to it as part of the planned cleanup for v2.24.
Proposed Changes
deserialize_document_store_in_init_params_inplacefromhaystack/utils/deserialization.pyhaystack/utils/__init__.pytest/utils/test_deserialization.pyRelated Issues
deserialize_document_store_in_init_params_inplace#10443How was this tested?
Ran unit tests locally:
All tests passed successfully.
Notes for the Reviewer
Checklist
!to indicate a breaking change.