chore: Refactor pipeline run tests #10451
Merged
+462
−1,261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
sjrl
commented
Jan 26, 2026
Comment on lines
-136
to
-146
| @then("draw it to file") | ||
| def draw_pipeline(pipeline_data: tuple[Pipeline, list[PipelineRunData]], request: pytest.FixtureRequest) -> None: | ||
| """ | ||
| Draw the pipeline to a file with the same name as the test. | ||
| """ | ||
| if m := PIPELINE_NAME_REGEX.search(request.node.name): | ||
| name = m.group(1).replace(" ", "_") | ||
| pipeline = pipeline_data[0] | ||
| graphs_dir = Path(request.config.rootpath) / "test_pipeline_graphs" | ||
| graphs_dir.mkdir(exist_ok=True) | ||
| pipeline.draw(path=graphs_dir / f"{name}.png") |
Contributor
Author
There was a problem hiding this comment.
I removed this utility function since it wasn't used in the tests.
sjrl
commented
Jan 26, 2026
sjrl
commented
Jan 26, 2026
Comment on lines
-1550
to
-1556
| [ | ||
| PipelineRunData( | ||
| inputs={ | ||
| "prompt": {"question": "This is a question that has an answer", "columns": columns}, | ||
| "router": {"question": "This is a question that has an answer"}, | ||
| }, | ||
| expected_outputs={"sql_querier": {"results": "This is the query result", "query": "Some SQL query"}}, |
Contributor
Author
There was a problem hiding this comment.
This example was removed since it was left over accidentally and already being skipped. It's a copy from a different test.
sjrl
added
the
ignore-for-release-notes
Collaborator
Pull Request Test Coverage Report for Build 21361008047Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
While working on adding more tests for the auto joiner experiment I found there was many opportunities to reduce duplicate code and code lines in the pipeline run tests.
How did you test it?
Existing tests. Didn't remove or add tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.