Skip to content

Conversation

@anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 26, 2026

Related Issues

Flaky test reported in #10341 (comment)

This test likely failed because another test workflow ran at the same time.

In fact, GitHub REST API rate limits for search operations (like the one used in the test) are quite low; they are lower than limits on core operations.

Proposed Changes:

  • run the integration test only on Ubuntu to avoid hitting rate limits

How did you test it?

CI

Notes for the reviewer

After discussion with @julian-risch, we decided it's useful to have an integration test but we only run it on Ubuntu to avoid rate limits

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jan 26, 2026 2:40pm

Request Review

@anakin87 anakin87 marked this pull request as ready for review January 26, 2026 12:53
@anakin87 anakin87 requested a review from a team as a code owner January 26, 2026 12:53
@anakin87 anakin87 requested review from julian-risch and removed request for a team January 26, 2026 12:53
@anakin87 anakin87 self-assigned this Jan 26, 2026
@coveralls
Copy link
Collaborator

coveralls commented Jan 26, 2026

Pull Request Test Coverage Report for Build 21361613535

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.446%

Totals Coverage Status
Change from base Build 21353884971: 0.0%
Covered Lines: 14758
Relevant Lines: 15964

💛 - Coveralls

@anakin87 anakin87 changed the title test: use a core operation in test_github_api_integration flaky test test: run test_github_api_integration test only on Ubuntu to avoid rate limits Jan 26, 2026
@anakin87 anakin87 enabled auto-merge (squash) January 26, 2026 14:43
@anakin87 anakin87 merged commit 97d6dac into main Jan 26, 2026
18 checks passed
@anakin87 anakin87 deleted the openapi-connector-flaky-test branch January 26, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants