Skip to content

chore: Deprecate deserialize_document_store_in_init_params_inplace #10442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julian-risch merged 4 commits into from
Jan 23, 2026
Merged

chore: Deprecate deserialize_document_store_in_init_params_inplace #10442

julian-risch merged 4 commits into from
Jan 23, 2026
+17 −0

Conversation

@julian-risch
Copy link
Member

@julian-risch julian-risch commented Jan 23, 2026

Related Issues

Proposed Changes:

  • Add a DeprecationWarning to deserialize_document_store_in_init_params_inplace

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@julian-risch julian-risch requested a review from a team as a code owner January 23, 2026 14:52
@julian-risch julian-risch requested review from sjrl and removed request for a team January 23, 2026 14:52
@vercel
Copy link

vercel bot commented Jan 23, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
haystack-docs Ignored Ignored Preview Jan 23, 2026 4:24pm

Request Review

@github-actions github-actions bot added the type:documentation Improvements on the docs label Jan 23, 2026
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 21293152299

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.446%
Totals Coverage Status
Change from base Build 21288970581: 0.001%
Covered Lines: 14758
Relevant Lines: 15964
💛 - Coveralls

anakin87
anakin87 reviewed Jan 23, 2026
View reviewed changes
@anakin87 anakin87 removed the request for review from sjrl January 23, 2026 14:57
anakin87
anakin87 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Feel free to open an issue to schedule the removal of this function

@julian-risch julian-risch mentioned this pull request Jan 23, 2026
Open
@julian-risch
Copy link
Member Author

julian-risch commented Jan 23, 2026

Feel free to open an issue to schedule the removal of this function

Good point! 👍 #10443

@julian-risch julian-risch enabled auto-merge (squash) January 23, 2026 16:34
@julian-risch julian-risch merged commit a03b6fc into main Jan 23, 2026
21 checks passed
@julian-risch julian-risch deleted the deprecate-deserialize-doc-store branch January 23, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees

No one assigned

Labels

type:documentation Improvements on the docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a DeprecationWarning to deserialize_document_store_in_init_params_inplace

4 participants

@julian-risch @coveralls @anakin87