enhancement: support flattened verbosity generation_kwarg for OpenAIResponsesChatGenerator #10436
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponsesChatGenerator
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
Pull Request Test Coverage Report for Build 21282692151Details
💛 - Coveralls |
tstadel
commented
Jan 23, 2026
Comment on lines
+490
to
+491
| reasoning_effort = generation_kwargs.pop("reasoning_effort", None) | ||
| if reasoning_effort is not None: |
Member
Author
There was a problem hiding this comment.
Just some better null value handling. I.e. don't set it to the nested structure if the user set it to None.
sjrl
reviewed
Jan 23, 2026
Comment on lines
+478
to
+481
| # if `text_format` is provided, we use the `parse` endpoint for response type parsing | ||
| if generation_kwargs.get("text_format"): | ||
| # if both `text_format` and `text` are provided, `text_format` takes precedence | ||
| # and json schema passed to `text` is ignored |
Contributor
There was a problem hiding this comment.
I see that it was based on your release note
tstadel
deleted the
enhancement/openai_responses_support_flat_verbosity_generation_kwarg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
verbositygeneration_kwarg for OpenAIResponsesChatGeneratorOpenAI.responses.parsewhen notext_formattype is given (to convert the response into this type)How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.