-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: Simplify to_dict, from_dict with default (de-)serialization of objects
#10435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Collaborator
Pull Request Test Coverage Report for Build 21288641956Details
💛 - Coveralls |
to_dict, from_dict with default (de-)serialization of objects
anakin87
reviewed
Jan 23, 2026
Member
anakin87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two comments.
On the other points you brought up:
- Ok with keeping
AzureOpenAIResponsesChatGeneratoras is - Let's deprecate
deserialize_document_store_in_init_params_inplaceas you suggest
anakin87
reviewed
Jan 23, 2026
anakin87
approved these changes
Jan 23, 2026
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
to_dict,from_dictwith default (de-)serialization of init parameter objects that defineto_dict,from_dict#10433Proposed Changes:
How did you test it?
Notes for the reviewer
Simplifying AzureOpenAIResponsesChatGenerator
to_dictThe only other class that I see could be updated is the AzureOpenAIResponsesChatGenerator but I decided against it. The current version makes it easier to understand in one location of the code how AzureOpenAIResponsesChatGenerator's Secret is serialized instead of spreading it across the AzureOpenAIResponsesChatGenerator class and the default_to_dict logic.
We could do sth like
Happy to discuss.
Deprecating
deserialize_document_store_in_init_params_inplacedeserialize_document_store_in_init_params_inplaceis no longer used in Haystack and it also isn't used in any of the deepset maintained integrations in haystack-core-integrations. It would be still a breaking change to remove it, so we could deprecate it now and then remove it entirely in a later version of Haystack. If we decide to do that, I can open a separate PR. Happy to discuss this too.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.