Skip to content

Code review f.cueto10 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipecuetor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code review f.cueto10 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/main.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<head>
<meta charset="utf-8">
<meta http-equiv="content-language" content="es">
<!--Adaptar para al nuevo proyecto-->
<title>KipCount</title>
<link rel="shortcut icon" href="favicon.ico">

Expand Down
3 changes: 2 additions & 1 deletion imports/api/peopleCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { Mongo } from 'meteor/mongo';
import { Meteor } from 'meteor/meteor';
import { check } from 'meteor/check';

export const PeopleCollection = new Mongo.Collection('people');
//Puede que mongo no sea la BD correcta para esta aplicacion, si las personas van a confiar en esta aplicacion puede ser necesario una BD SQL.

export const PeopleCollection = new Mongo.Collection('people');

if (Meteor.isClient) {
Template.dashboard.events({
Expand Down
1 change: 1 addition & 0 deletions imports/ui/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import View from './View.jsx';
import NavBar from './NavBar.jsx';

// App component - represents the whole app

class App extends Component {

constructor(props)
Expand Down
2 changes: 1 addition & 1 deletion imports/ui/ModalAddFoundPerson.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,4 @@ export default class ModalAddFoundPerson extends Component {

);
}
}
}
1 change: 1 addition & 0 deletions imports/ui/OutsideAccountsUIWrapper.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Template } from 'meteor/templating';
import { Blaze } from 'meteor/blaze';

export default class OutsideAccountsUIWrapper extends Component {
//Buena utilizacion de templates
componentDidMount() {
// Use Meteor Blaze to render login buttons
this.view = Blaze.render(Template.ourLoginBar,
Expand Down
4 changes: 2 additions & 2 deletions imports/ui/PersonDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default class PersonDetail extends Component {
{
super(props);
}

//no se utiliza el atributo State de una persona, recomendaria agregarlo a los detalles o eliminarlo de la BD
render() {
if(this.props.person)
{
Expand Down Expand Up @@ -71,4 +71,4 @@ export default class PersonDetail extends Component {
);
}
}
}
}
1 change: 1 addition & 0 deletions imports/ui/View.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import ModalAddWantedPerson from './ModalAddWantedPerson';
import LoginFormsAccountsUIWrapper from './LoginFormsAccountsUIWrapper.jsx';
import OutsideAccountsUIWrapper from './OutsideAccountsUIWrapper.jsx';

//Recomendaria agregar mas parametros a la busqueda de personas en una busqueda avanzada
export default class View extends Component {
constructor(props)
{
Expand Down