Fix URL encoding in AMCP thumbnail commands to preserve path separators#1
Draft
Fix URL encoding in AMCP thumbnail commands to preserve path separators#1
Conversation
Copilot
AI
changed the title
[WIP] Fix URL encoding error for thumbnail retrieve commands
Fix URL encoding in AMCP thumbnail commands to preserve path separators
Jan 17, 2026
- Add url_encode_path() function to handle file paths properly - Encode path components while preserving forward slash separators - Support both Windows backslashes and Unix forward slashes - Update AMCP commands: thumbnail_retrieve, thumbnail_generate, cinf - Improve HTTP error messages with actual status codes - Replace stringstream with direct string operations for better performance - Follow RFC 3986 for URL encoding of unreserved characters Fixes issue where file paths with spaces caused 404 errors in thumbnail retrieval and other media-scanner HTTP requests.
dedicatedbroadcastsolutions
force-pushed
the
copilot/fix-thumbnail-url-encoding
branch
from
a469e90 to
0d53f1b
Compare
Debian package versions don't allow underscores. Update the workflow to replace underscores (along with slashes and spaces) with hyphens when generating the build version from the branch name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
url_encodefunction was encoding forward slashes as%2F, breaking file paths in AMCP thumbnail/media query commands.Changes
/to unreserved characters inurl_encode()Example
Before:
After:
Affects:
THUMBNAIL RETRIEVE,THUMBNAIL GENERATE,CINFcommandsNote: This function is only used for path components, not query parameters where
/would need encoding.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.