LRA improvements #34
Merged
LRA improvements #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added convergence steps, implemented proper broadcasting where appropriate, removed hardcoded values for e.g. initializing arrays, removed hardcoded model and sbox definition, now uses configurable models, generalized variable names towards model positions, in-lined various functions into LRA() classes, removed self.samples_range option (prefer container.slab), added option for bias bit to all algos, added normalize option to lra.py, added new classes to model_values to support these changes: MultiModel to calculate against several models at once, Sbox (e.g. instead of SboxWeight), ModelBits to use unpacked model output, Added __len__ method to ModelValue which abstracts multi_model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dos2unix lra.pyto match rest of project