Updated to use ZarrV3 and NumpyV2#31
Merged
decryptofy merged 1 commit intodecryptofy:mainfrom Oct 7, 2025
Merged
Conversation
Contributor
|
The jupyter notebooks should probably be updated as well. e.g. in zarr v3, Otherwise, I ran this PR on CPA and had no issues. |
Owner
|
there is a minor typo in the versioning for Zarr: ought to be 3.0.4 but currently is: 3.04 -- please update and I'm happy to merge |
Author
|
I have amended the typo, and will also do a pull request for the supporting Jupyter submodule. I hope this is satisfactory! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I modified the code to use Zarr V3 instead of ZarrV2, and updated it to a more recent version of NumPy. It's a simple change, but I hope this fits your outline for a "Patch Proposal" as well as any necessary license requirements. I performed testing locally, and it seems to be working well thus far.
Thank you for your time