Open
Conversation
Member
|
So this PR needs to be split in two. One for the logging bit and then we need to debate why retrying helps. |
Member
Author
|
Should we just leave the logging on this one then? @marcopeereboom |
Member
Yes. Remove the reconnection logic and create a new issue for that. Then let's debate why we need it and how to implement it. This version seems wrong to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff adds a retry connection loop when dcrtimed is unable to connect to dcrwallet. It also adds a subsystem logger for
dcrtimewalletso that it's able to log on the console.closes #62