Conversation
amass01
force-pushed
the
golanglint-ci
branch
2 times, most recently
from
81103fb to
357692d
Compare
amass01
commented
Jul 17, 2025
Comment on lines
-10
to
-11
| - gofmt | ||
| - goimports |
amass01
commented
Jul 17, 2025
| - bodyclose | ||
| - gofmt | ||
| - goimports | ||
| - gosimple |
Member
Author
There was a problem hiding this comment.
it's part of staticcheck
| - rowserrcheck | ||
| - sqlclosecheck | ||
| - tparallel | ||
| - typecheck |
amass01
force-pushed
the
golanglint-ci
branch
7 times, most recently
from
3ed6bc0 to
89fe739
Compare
davecgh
reviewed
Jul 17, 2025
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
I've been holding off on merge the PR in dcrd that does this because the last time I checked the release version of gopls doesn't work properly with v2 yet (but it does on the development branch).
If the active developers on this repo don't care about not seeing proper lint warnings in their editor until a new version of gopls with those updates is released, I have no objection to merging it for this repo.
davecgh
reviewed
Jul 17, 2025
davecgh
approved these changes
Jul 18, 2025
jrick
requested changes
Jul 18, 2025
jrick
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.