feat: pre-load assets #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test this pull request on NPM or Yarn
|
gonpombo8
reviewed
Jan 9, 2026
|
|
||
| // AssetLoadLoadingState is set by the engine and provides information about | ||
| // the current state of the AssetLoad of an entity. | ||
| message PBAssetLoadLoadingState { |
Contributor
There was a problem hiding this comment.
this is a Grow Only Set ?
if not we should have an array here as well, because if not how we gave granularity in all the assets that we asked to pre load /
Author
There was a problem hiding this comment.
it's the same type of PointerEventsResult and will be handled by the client in the same way by appending messages
Contributor
There was a problem hiding this comment.
great !
We should add a comment then like the pointerEventResult that tells that is appending values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.