-
Notifications
You must be signed in to change notification settings - Fork 3
feat: update dependencies and enhance MANA transfer views #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AndresMorelos
commented
Jan 12, 2026
- Upgraded @dcl/schemas to version 22.0.0 and decentralized-ui2 to version 1.1.7
- Added notification functionality in RequestPage for successful MANA transfers
- Enhanced RecipientProfileText component to show both name and address with address shortening in MANA transfer views
- Updated environment configuration files to include notifications processor URLs and tokens
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Upgraded @dcl/schemas to version 22.0.0 and decentralized-ui2 to version 1.1.7 - Added notification functionality in RequestPage for successful MANA transfers - Enhanced RecipientProfileText component to show both name and address with address shortening in MANA transfer views - Updated environment configuration files to include notifications processor URLs and tokens
8b712f1 to
2776e56
Compare
… components - Changed mana amount formatting from float to integer in RequestPage. - Updated font sizes and styles in SharedTransferComponents and MANATransferCompleteView for better readability. - Improved layout and structure in MANATransferCanceledView for clearer presentation of information.
| /** | ||
| * MANA Transfer Canceled View specific styled components | ||
| * Most components are imported from SharedTransferComponents | ||
| */ | ||
| export { SecondaryText } from '../../SharedTransferComponents.styled' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no need to do this if we are going to use the same component without changing the style
| /** | ||
| * MANA Transfer specific styled components | ||
| * Most shared components are imported from SharedTransferComponents.styled.ts | ||
| */ | ||
| export { | ||
| CenteredContent, | ||
| Title, | ||
| RecipientProfile, | ||
| RecipientProfileText, | ||
| Label as CreatorLabel, | ||
| InfoAlert | ||
| } from '../SharedTransferComponents.styled' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
| import Lottie from 'lottie-react' | ||
| import { styled } from 'decentraland-ui2' | ||
|
|
||
| export const SceneImageWrapper = styled('div')({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use Box instead of div
| export const SceneImageWrapper = styled('div')({ | ||
| width: '260px', | ||
| height: '260px', | ||
| marginBottom: '16px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thise should be
| marginBottom: '16px', | |
| marginBottom: theme.spacing(2), |
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| '& img': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lint comment is no needed, you can do this
| // eslint-disable-next-line @typescript-eslint/naming-convention | |
| '& img': { | |
| ['& img']: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should live in components and in separate components