Skip to content

Conversation

@AndresMorelos
Copy link
Contributor

  • Upgraded @dcl/schemas to version 22.0.0 and decentralized-ui2 to version 1.1.7
  • Added notification functionality in RequestPage for successful MANA transfers
  • Enhanced RecipientProfileText component to show both name and address with address shortening in MANA transfer views
  • Updated environment configuration files to include notifications processor URLs and tokens

@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
auth Ready Ready Preview, Comment Jan 16, 2026 9:32pm

Request Review

- Upgraded @dcl/schemas to version 22.0.0 and decentralized-ui2 to version 1.1.7
- Added notification functionality in RequestPage for successful MANA transfers
- Enhanced RecipientProfileText component to show both name and address with address shortening in MANA transfer views
- Updated environment configuration files to include notifications processor URLs and tokens
… components

- Changed mana amount formatting from float to integer in RequestPage.
- Updated font sizes and styles in SharedTransferComponents and MANATransferCompleteView for better readability.
- Improved layout and structure in MANATransferCanceledView for clearer presentation of information.
Comment on lines 1 to 5
/**
* MANA Transfer Canceled View specific styled components
* Most components are imported from SharedTransferComponents
*/
export { SecondaryText } from '../../SharedTransferComponents.styled'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no need to do this if we are going to use the same component without changing the style

Comment on lines 3 to 14
/**
* MANA Transfer specific styled components
* Most shared components are imported from SharedTransferComponents.styled.ts
*/
export {
CenteredContent,
Title,
RecipientProfile,
RecipientProfileText,
Label as CreatorLabel,
InfoAlert
} from '../SharedTransferComponents.styled'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

import Lottie from 'lottie-react'
import { styled } from 'decentraland-ui2'

export const SceneImageWrapper = styled('div')({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use Box instead of div

export const SceneImageWrapper = styled('div')({
width: '260px',
height: '260px',
marginBottom: '16px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thise should be

Suggested change
marginBottom: '16px',
marginBottom: theme.spacing(2),

Comment on lines 17 to 18
// eslint-disable-next-line @typescript-eslint/naming-convention
'& img': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lint comment is no needed, you can do this

Suggested change
// eslint-disable-next-line @typescript-eslint/naming-convention
'& img': {
['& img']: {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should live in components and in separate components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants