Skip to content

Conversation

@sdahdah
Copy link
Member

@sdahdah sdahdah commented May 10, 2025

Resolves #188

Proposed Changes

  • Update estimators to pass new scikit-learn estimator checks
  • Pin range of scikit-learn versions
  • Add Python 3.13 to CI

Checklist

  • Write unit tests
  • Add new estimators to existing scikit-learn compatibility tests
  • Write examples in docstrings
  • Update Sphinx documentation
  • Bump version number and date in setup.py, CITATION.cff, and
    README.rst

@sdahdah sdahdah linked an issue May 10, 2025 that may be closed by this pull request
@sdahdah sdahdah self-assigned this May 10, 2025
@sdahdah sdahdah added the bug Something isn't working label May 10, 2025
Copy link

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - confirming this resolves #188 for me locally and from a quick look through diff all changes look sensible to me.

@sdahdah sdahdah merged commit a889b0a into main May 12, 2025
8 checks passed
@sdahdah sdahdah deleted the bugfix/188-some-tests-failing-when-running-locally-in-python-313-environment branch May 12, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some tests failing when running locally in Python 3.13 environment

2 participants