Fix few hlint warnings, fix cabal check warning, improve haddocks#4
Merged
debug-ito merged 1 commit intodebug-ito:hlint-cabal-check-fixesfrom Mar 28, 2025
Conversation
jhrcek
commented
Mar 25, 2025
| category: Control | ||
| cabal-version: 2.0 | ||
| build-type: Simple | ||
| extra-source-files: README.md, ChangeLog.md |
Contributor
Author
There was a problem hiding this comment.
Explanation for this change:
$ cabal check
These warnings may cause trouble when distributing the package:
Warning: [doc-place] Please consider moving the file 'ChangeLog.md' from the
'extra-source-files' section of the .cabal file to the section
'extra-doc-files'
Owner
There was a problem hiding this comment.
Maybe we should put README.md in extra-doc-files, too?
Contributor
Author
There was a problem hiding this comment.
At the moment cabal doesn't raise a warning about readme.
Checking the cabal source code I see there's no specific check for readme (it's commented out).
Also most packages on hackage that I checked have readme mentioned as extra-source-file, so it should be fine.
debug-ito
merged commit 4d960e6
into
debug-ito:hlint-cabal-check-fixes
11 checks passed
Contributor
Author
|
Oops, now I noticed that this PR mistakenly targetted |
Owner
|
Don't worry. It was I who changed the target branch. I just wanted to do some more work before merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this nice package, it's exactly what I need to solve the issue I have.
Please accept this assortment of small fixes and improvements as a token of my gratitude 😸