331 i18n #334
Merged
331 i18n #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reactol ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| // note: we get an error if dev-tools is open, ignore that error. | ||
| } else { | ||
| setMessage({ title: 'Error', severity: 'error', message: 'Failed to read clipboard: ' + error }) | ||
| setMessage({ title: 'Error', severity: 'error', message: t('layers.readClipboardError') + error }) |
There was a problem hiding this comment.
Consider converting the 'error' object to a string (e.g., using String(error) or error.message) to ensure the displayed message is clear and consistent.
Suggested change
| setMessage({ title: 'Error', severity: 'error', message: t('layers.readClipboardError') + error }) | |
| setMessage({ title: 'Error', severity: 'error', message: t('layers.readClipboardError') + String(error) }) |
| addTabToLayout(newTab) | ||
| } catch (e) { | ||
| setMessage({ title: 'Error', severity: 'error', message: 'The file content is not a valid JSON format. Please check the file and try again. ' + e }) | ||
| setMessage({ title: t('documents.error'), severity: 'error', message: t('documents.invalidJsonError') + ' ' + e }) |
There was a problem hiding this comment.
Consider explicitly converting the error 'e' to a string (using String(e) or e.message) to avoid potential formatting issues in the error message.
Suggested change
| setMessage({ title: t('documents.error'), severity: 'error', message: t('documents.invalidJsonError') + ' ' + e }) | |
| setMessage({ title: t('documents.error'), severity: 'error', message: t('documents.invalidJsonError') + ' ' + e.message }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331