331 i18n #332
Closed
331 i18n #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reactol ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 8 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- package.json: Language not supported
- src/locales/en.json: Language not supported
- src/locales/it.json: Language not supported
- src/locales/nl.json: Language not supported
| return ( | ||
| <select onChange={(e) => i18n.changeLanguage(e.target.value)}> | ||
| <option value="en">English</option> | ||
| <option value="it">Italiano</option> |
There was a problem hiding this comment.
[nitpick] The LanguageSelector component does not include an option for Dutch ('nl') despite the i18n configuration providing Dutch translations. Consider adding a Dutch option to align with the available languages.
Suggested change
| <option value="it">Italiano</option> | |
| <option value="it">Italiano</option> | |
| <option value="nl">Nederlands</option> |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Drop this attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331