Agregando services#1
Open
roli93 wants to merge 2 commits intoclase-2-platos-y-comandas-sin-servicesfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notas:
Los métodos
buscarComandayverComandadeComandaControllerno tenían suficiente lógica adicional como -ara que se justificara agregar el service en el medio, ya que habrian terminado siendo pasamanos. Además, si pensamos en las interfaces (es decir, que datos consumen y devuelven) de hipotéticosbuscarComandayverComandaa nivel de service, podemos notar que consumen y devuelven valores primitivos simples o la Comanda en sí, que no generan un acoplamiento adicional innecesario entre el Controller y el Service.El
PlatoServicetiene bastante poca lógica y sólo dos métodos, y la mayoría de las operaciones del Controller no lo utilizan. En este caso sería también válido argumentar que, por simplicidad, no se justifica hacer este Service por el momento.