Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #61 where xdebug and xhprof extensions fail to load in FrankenPHP because the copied ini files reference the wrong shared object file names. The php-zts extensions use versioned naming (e.g., xdebug-zts-84.so) instead of the standard naming (e.g., xdebug.so).
Changes:
- Adds sed commands to update the ini file references from standard
.sonames to versioned-zts-XX.sonames for xdebug and xhprof extensions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stasadev
reviewed
Jan 23, 2026
Member
stasadev
left a comment
There was a problem hiding this comment.
Thanks.
We also needs a proper validation in tests, to prevent things like this in the future.
I'm going to look closer into this, maybe it's better not to rely entirely on our ini files.
ce319a3 to
7ec070a
Compare
f89b982 to
5e4d3a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Updates configuration to append
xdebug.iniandxhprof.iniconfig dynamically without hardcoding.Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes