This repository was archived by the owner on Nov 3, 2024. It is now read-only.
Open
Conversation
Member
|
Shouldn't this go into ddev's docs? |
Author
|
As well as here? Probably. Found a solution and wanted to contribute back is all :) . The docs have pointed to this repo for anything on the level of adding custom docker-compose partials. |
Member
|
Yeah, just improve https://ddev.readthedocs.io/en/stable/users/extend/customization-extendibility/#providing-custom-environment-variables-to-a-container - I've been meaning to explore this feature of docker-compose and didn't get it done yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The New Solution/Problem/Issue/Bug:
No env file support provided on the env snippet.
How this PR Solves The Problem:
Provides example snippet with comment. Allows docker-compose to load env files. This is a widely known issue with ddev, i.e. the lack of env file support.
Taken from the offical docs:
https://docs.docker.com/compose/environment-variables/#the-env_file-configuration-option
Manual Testing Instructions:
print_r($_ENV);Related Issue Link(s):