Properly link in libudev once it is found#17
Closed
CuriouslyCurious wants to merge 1 commit intodcuddeback:masterfrom
Closed
Properly link in libudev once it is found#17CuriouslyCurious wants to merge 1 commit intodcuddeback:masterfrom
CuriouslyCurious wants to merge 1 commit intodcuddeback:masterfrom
Conversation
This fixes a subtle issue where libudev-rs assumes that the library files are properly linked in which can result in a seemingly mysterious SIGSEGV when using a musl-based libc distribution. See [https://github.com/probe-rs/probe-rs/issues/2148](https://github.com/probe-rs/probe-rs/issues/2148) for details.
Author
|
I see now that another PR does more fixes to the build.rs than just this small change so I will refer to that one instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a subtle issue where libudev-rs assumes that the library files are properly linked in which can result in a seemingly mysterious SIGSEGV when using a musl-based libc distribution.
See probe-rs/probe-rs#2148 for details.