Fix blocking IO issues in luxor_openapi_asyncio module#4
Open
DigitalBites wants to merge 3 commits intodcramer:mainfrom
Open
Fix blocking IO issues in luxor_openapi_asyncio module#4DigitalBites wants to merge 3 commits intodcramer:mainfrom
DigitalBites wants to merge 3 commits intodcramer:mainfrom
Conversation
Author
|
@dcramer thoughts on the above? This was done with compatible changes for openapi generator openapi-generator-cli-5.2.1.jar (it seemed like this was what was used based on the files in the repo). I did try the latest and was getting some strange errors on number of parameters and reverted to the initial version you used which appears to continue to generate and work ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to update the template used to generate the rest.py file.
Enabled a check to see if configuration.ssl_context is provided and then use this context avoiding IO during default certificate configuration reads from the file system.
A new luxor_openapi_asyncio version 0.1.0 -> 0.2.0 or similar will need to be rolled so I can merge the one line change in the hass_luxor integration.
closes #3