-
-
Notifications
You must be signed in to change notification settings - Fork 10
V2.0.5 #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.0.5 #141
Changes from all commits
bd6b102
c71478a
f639817
e64c916
95acb16
5b1f71d
c4629d4
4cd8424
841f396
8008c98
e8d60ed
2f5aefe
c5d8b7e
9bf5dda
dda6150
f88c0f9
ac8a8c4
aad842f
97c422d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -121,6 +121,12 @@ public function connectTimeout(int $seconds): PendingRequest | |||||||||||||||||||||||||||||||
| return $this; | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| public function unixSocketPath(string $path): PendingRequest | ||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||
| $this->options['unix_socket_path'] = $path; | ||||||||||||||||||||||||||||||||
| return $this; | ||||||||||||||||||||||||||||||||
|
Comment on lines
+124
to
+127
|
||||||||||||||||||||||||||||||||
| public function unixSocketPath(string $path): PendingRequest | |
| { | |
| $this->options['unix_socket_path'] = $path; | |
| return $this; | |
| /** | |
| * Alias for {@see PendingRequest::unixSocket()}. | |
| * | |
| * @deprecated Use {@see PendingRequest::unixSocket()} instead. | |
| * | |
| * @param string $path Absolute or relative filesystem path to the Unix socket file. | |
| * @return PendingRequest Returns the current instance for fluent chaining. | |
| */ | |
| public function unixSocketPath(string $path): PendingRequest | |
| { | |
| return $this->unixSocket($path); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,13 +68,16 @@ public function __construct(string $stateKey, $default) | |
| * @param mixed $value Optional value to be processed when the object is invoked. | ||
| * @return mixed The result of the invocation, depending on the implementation. | ||
| */ | ||
|
Comment on lines
68
to
70
|
||
| public function __invoke($value = UNDEFINED_STATE_VARIABLE) | ||
| public function __invoke() | ||
| { | ||
| $sessionData = SessionHandler::get(STATE_HANDLE); | ||
|
|
||
| if ($value === UNDEFINED_STATE_VARIABLE) { | ||
| // If no argument was passed, return the current state value. | ||
| if (\func_num_args() === 0) { | ||
| return $sessionData[$this->stateKey] ?? $this->value; | ||
| } | ||
| // An argument was explicitly provided (even if it is falsy); treat it as the new state value. | ||
| $value = func_get_arg(0); | ||
|
|
||
| $this->lastState = $this->value ?? Validate::validate($value); | ||
| $this->value = $value; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the default SSL verification from
falsetotrueis a breaking change for existing code that relies on the current default behavior. This could cause existing HTTP requests to fail if they were connecting to endpoints with self-signed certificates or other SSL issues. While enabling SSL verification by default is a security best practice, this change should be clearly documented as a breaking change in the changelog and potentially versioned as a major release (v3.0.0) rather than a patch release (v2.0.5).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback