Skip to content

Added a feature to customize length of the pattern#8

Open
garciadelcastillo wants to merge 5 commits intodchudz:masterfrom
ParametricCamp:master
Open

Added a feature to customize length of the pattern#8
garciadelcastillo wants to merge 5 commits intodchudz:masterfrom
ParametricCamp:master

Conversation

@garciadelcastillo
Copy link

Includes a checkbox for square pattern or not, plus a text box for a custom number of rows.
Works with the state in the URL.

image

@garciadelcastillo
Copy link
Author

@dchudz
Copy link
Owner

dchudz commented Apr 9, 2023

Hi @garciadelcastillo! Thanks for doing this. I'm about 80 minutes into the video. Cool stuff. Very sorry about the dependency troubles at the beginning. I think I made your life harder by merging a broken PR from dependabot.

Screen Shot 2023-04-09 at 8 37 42 AM

Overall this looks great but I think it's a bit confusing that the Custom number of rows: question shows up even when the user has Square pattern? checked. What would you think of hiding that line until "square" is unchecked? (Or I can probably merge this and then take care of that myself if you prefer.)

@garciadelcastillo
Copy link
Author

You are very right, that would feel better from an UI perspective.

Give me a few days and I will push some edits to this PR.

@dchudz
Copy link
Owner

dchudz commented Apr 13, 2023

Great!

Thinking a little more, another option might be:

  • rows input greyed-out if "square" is checked
  • rows input (when greyed out) shows a number that exactly matches the height (since you have a square)

But what I said before would be good too I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants