Fixes some issues with asserts regarding the kernel_size and padding … #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments, and adds code to construct the correct padding from kernel_size automatically for padding_mode = 'circular'. Tests are passing. 1. Some asserts were failing for certain valid arguments due to comparing tuples with ints or lists, now all variables are forced to be tuples once this point is reached. 2. padding_mode = 'zeros' is not the same as padding = 0, this condition has been removed from the assert ensuring that padding != 0 only for padding_mode = 'circular'. 3. For a given kernel_size and padding_mode = 'circular', the appropriate padding must be kernel_size-1. This was checked with an assert already, but now it can also be ensured autoamtically by passing padding = None together with padding_mode = 'circular'.
…y for ddp to work)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arguments, and adds code to construct the correct padding from kernel_size automatically for padding_mode = 'circular'. Tests are passing.