Conversation
devhawk
commented
Feb 23, 2026
| return "\"%s\"".formatted(schema); | ||
| return Objects.requireNonNullElse(schema, Constants.DB_SCHEMA) | ||
| .replace("\0", "") | ||
| .replace("\"", "\"\""); |
Collaborator
Author
There was a problem hiding this comment.
I'm thinking here we should just remove single and double quotes, like we remove the null char. This will allow the schema to be used as a schema in queries as well as a value in Migration #10
Member
There was a problem hiding this comment.
I'd prefer it just fail outright with a clear error message
Collaborator
Author
There was a problem hiding this comment.
I added an explicit check for schemas with a single or double quote in them
kraftp
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sanitizeSchemamethod originally added changed"to""and added double quotes around the entire schema so that it would support schema names with single and double quotes in them such asC$+0m'. However, this approach is not compatible with Migration #10, where we need to use the schema name as a column value.