-
Notifications
You must be signed in to change notification settings - Fork 41
Add support to subset files in time for stats analysis #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Updated filtering conditions to use 'Localtime' for date range checks.
Added entry for temporal subsetting in raiderCombine.py and other updates.
| raider_folder: Path | ||
| gnss_folder: Path | ||
| raider_folder: List[Path] | ||
| gnss_folder: List[Path] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sssangha could this be Union[List[Path], Path]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the logic more consistent overall in the code, but the logic is as follows:
- Support wildcard/multiple path input in the parser
- Split into a list discrete individual paths and push them through as individual paths through the downstream function.
I verified the outputs I get now vs before this little clean-up are consistent though, so the files are being pushed through as we'd expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jlmaurer , following up. I worked this out and enforced consistency in the workflow. Please let me know what you think. Thanks
Updated the environment.yml file to include 'geopandas' and 'pyogrio' as dependencies, and modified the update command to use the '--prune' option.
Added support within the
raiderCombine.pypipeline to support temporal subsetting, which is introduced as a new option--timeinterval.If a valid argument is provided, temporal sampling is performed in 2 phases:
--timeintervalin order to not lose valid observations due to time zone changes.--timeintervalonce 'Localtime' has been computedScreenshots (if appropriate):
Type of change
Checklist: