Skip to content

skip directories and other non-note files #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamilyon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

skip directories and other non-note files #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions autocatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ def __init__(self, file_name):
self.space = self.paths[1]
self.note = self.paths[2]
self.file = self.paths[3]
if self.file in ("note.txt", "note.html"):

if self.file !="note.enex":
Copy link
Owner

@davious davious Aug 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is more comprehensive than the two file check; as far as I knew, there was only three files in a note folder... except for the All Notes note folders, then there might be attachments. I don't want to exclude attachments.

raise Exception(self.file + " files are not considered NoteFiles: " + file_name)
if self.file == "note.enex" and self.space == "All Notes":
if self.space == "All Notes":
Copy link
Owner

@davious davious Aug 30, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the attachments in the All Notes space note folders; so, let's not ignore the All Notes note folders completely.

You mention that the original script wasn't working for you. I invite our collaboration on finding the root of the problem and adding the fix to the script.

raise Exception("Not interested in All Notes note.enex files: " + file_name)

class NoteImporter:
Expand Down