Stdout empty lines in post window#258
Open
bsssssss wants to merge 2 commits intodavidgranstrom:mainfrom
Open
Conversation
Empty lines on stdout were discarded to avoid duplication of new lines, but they should be visible in the post window.
bsssssss
force-pushed
the
fix/post-empty-lines
branch
from
aa67d35 to
cf031d2
Compare
Owner
|
Thanks for this, I will try it out! Please have a look at the failing "lint and style" check if you have the time so that the CI passes. |
Author
|
Fixed it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little fix that allows posting empty lines in the post window, so that stdout is properly reflected.
Hope I didn't miss some edge cases, but it seems to work well ! I guess the reason why it was simply discarded was to avoid duplicated empty lines ? If so this solution avoid that :)