Implement graceful shutdown for API server #35
Conversation
- Update `createApiServer` to return a `listen` helper that handles `SIGTERM` and `SIGINT` signals. - Update `createPromptServer` to expose the `listen` helper. - Update `dev` command to use the new `listen` helper and remove manual signal handling. - Fix Firebase plugin type export issue.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented graceful shutdown for the API server by adding SIGTERM and SIGINT handlers. This ensures that the HTTP server stops accepting new connections and ongoing tasks are cleaned up properly before the process exits.
Changes:
src/routing/server.ts:createApiServernow returns an object{ app, listen }. Thelistenfunction starts the server and registers signal handlers.src/core/dataprompt.ts:createPromptServernow returns thelistenhelper.src/cli/commands/dev.ts: Updated to use the newlistenhelper, removing redundant signal handling code.src/plugins/firebase/public.tsrelated to type exports.PR created automatically by Jules for task 11634777966003489575 started by @davideast