Fixed RESET functionality to emulate CPU behavior.#4
Open
niclash wants to merge 1 commit intodavepoo:masterfrom
Open
Fixed RESET functionality to emulate CPU behavior.#4niclash wants to merge 1 commit intodavepoo:masterfrom
niclash wants to merge 1 commit intodavepoo:masterfrom
Conversation
* LoadPrg is given address to load into, rather than having address in the beginning of its array.
|
@davepoo This PR seems correct to me, is there anything holding it back from getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally; LoadPrg is given address to load into, rather than having address in the beginning of its array.
RESET vector is not the position in memory where the CPU starts executing, but it contains the address to where the CPU should jump to and start to execute.
Also, just like
NumBytesis not in theProgramarray of bytes, neither should theLoadAddressbe, so it is passed as an argument.