feat: extract shared DateRangeFilter and ListTotalDisplay components (#215, #216)#249
Merged
daveharmswebdev merged 2 commits intomainfrom Feb 22, 2026
Merged
Conversation
- Add [showBorder]="true" to expenses ListTotalDisplay for visual consistency with income - Remove defensive ?? 0 on totalAmount (interface guarantees non-optional number) - Remove redundant `as DateRangePreset` type assertions in income store - Replace deprecated ::ng-deep with subscriptSizing="dynamic" on mat-form-field - Remove test for impossible scenario (missing totalAmount violating interface) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DateRangeFilterComponentandgetDateRangeFromPreset()utility to shared. Expenses and Income both now use the same date range filter with presets (All Time, This Month, This Quarter, This Year, Custom Range). Income upgraded from basic From/To pickers to preset-based filtering with sessionStorage persistence.ListTotalDisplayComponentfor consistent currency total display. AddedTotalAmountto backendPagedResult<T>viaSumAsyncbefore pagination. Both Expenses and Income pages show their respective totals using the shared component.Test plan
🤖 Generated with Claude Code