feat: add registry type

[puehringer]

See https://github.com/datavisyn/docker_infrastructure/pull/22 for details.

[Copilot]

Pull request overview

This PR adds support for configuring the ECR registry type (public or private) across GitHub Actions workflows and reusable actions. The changes enable the actions to work with both AWS ECR public and private registries by passing the registry type to the aws-actions/amazon-ecr-login action.

• Adds ecr_registry_type input parameter to three custom actions with a default value of "private" for backward compatibility
• Passes the ecr_registry_type parameter from the workflow to the pull-push-image action via the destination configuration
• Configures the aws-actions/amazon-ecr-login action to use the specified registry type

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
.github/workflows/build-docker-artifacts-push.yml	Adds destination_ecr_registry_type parameter to pass registry type configuration from AWS config to the pull-push-image action
.github/actions/retag-image/action.yml	Adds ecr_registry_type input with default "private" and passes it to amazon-ecr-login action
.github/actions/get-ecr-scan-result/action.yml	Adds ecr_registry_type input with default "private" and passes it to amazon-ecr-login action
.github/actions/build-push-image/action.yml	Adds ecr_registry_type input with default "private" and passes it to amazon-ecr-login action

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The AWS CLI commands used later in this action (lines 67, 74) are only compatible with private ECR registries. When ecr_registry_type is set to "public", these commands will fail as they need to use "aws ecr-public" instead of "aws ecr". Consider adding conditional logic in the scan results step to handle both registry types appropriately.