Capture null returns in type definitions#69
Merged
eyas-ranjous merged 1 commit intodatastructures-js:masterfrom Jan 6, 2025
Merged
Capture null returns in type definitions#69eyas-ranjous merged 1 commit intodatastructures-js:masterfrom
eyas-ranjous merged 1 commit intodatastructures-js:masterfrom
Conversation
eyas-ranjous
approved these changes
Dec 23, 2024
zhuangya
added a commit
to zhuangya/priority-queue
that referenced
this pull request
Dec 24, 2024
zhuangya
added a commit
to zhuangya/priority-queue
that referenced
this pull request
Dec 24, 2024
eyas-ranjous
pushed a commit
that referenced
this pull request
Jan 6, 2025
ref: #69 Co-authored-by: Ya Zhuang <zhuangya@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @eyas-ranjous, I noticed the same issue in this library that PR 35 fixed in the
datastructures-js/heapdependency.Hopefully not too controversial!