CNDB-14687: Consistent error messages in the event of a network timeout. #2194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age as a latch timeout. This creates a more consistent behavior in the event of different network timeouts, and has a side benefit of fixing three or four different flaky tests
Checklist before you submit for review
|
|
Restarted the CI job, hopefully that works: https://jenkins-stargazer.aws.dsinternal.org/job/ds-cassandra-pr-gate/job/PR-2194/ |
|
driftx
approved these changes
Jan 16, 2026
driftx
left a comment
driftx
left a comment
There was a problem hiding this comment.
Everything looks good. Butler didn't fire from the CI restart, but there weren't many failures and they were all timeouts that don't reproduce so aren't related to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
There are two different ways in which network timeouts are detected during Repair operations--there is a configured count-down latch which will fail if the requests take too long, and there is a separate timeout returned by the underlying messaging system. Unfortunately, when the underlying messaging system timed out, it was being treated as a general network error instead of a timeout. The net result is that very rarely the network will timeout before the count down latch, and some tests in the CI build will fail with an incorrect error message.
What does this PR fix and why was it fixed
This resolves https://github.com/riptano/cndb/issues/14687.
The main motivation is flaky unit tests, but the end user will also see a more consistent error message in the event of a network timeout that is detected at a lower level than the latch timeout.