Open
Conversation
Normalize the hash information to comply with Omniauth strategy developemnt recommendations: - remove key/value pairs from #info that are missing from the Omniauth Auth Hash Schema. - add all user information returned from Paypal as a value for the 'raw_info' key in #extra. Add tests for #info, #extra and also for #uid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omniauth describes the authentication hash schema for versions greater than 1.0 at https://github.com/omniauth/omniauth/wiki/Auth-Hash-Schema.
This pull request takes care of the following issues:
extra->raw_infoinstead of justextraas described in the Omniauth wikigiven_nameandfamily_name) are not returned underinfoas there already are clear, defined attributes for that kind of information (first_name``last_name). The fields are only kept as extra information about the user. The purpose of Omniauth is also to try and normalize different servicesAt the same time, tests are added for
#infoand#extrato verify compliance.