Skip to content

Conversation

@svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Aug 22, 2025

Purpose

Implement support for all GeoLocation sub-properties, including geoLocationPolygon.

related to: https://github.com/orgs/datacite/projects/28/views/21?pane=issue&itemId=87301285&issue=datacite%7Cproduct-backlog%7C88

Approach

Tested the unmodified MDS with updated bolognese and lupo in my local development environment. Created a DOI with all geoLocation fields. Everything worked, so no code changes are necessary, except for added specs.

Updated bolognese to latest released version and tested.

Open Questions and Pre-Merge TODOs

  • Deploy bolognese and lupo code changes for geoLocation.
  • Update Gemfile/Gemfile.lock to include the latest versions of: lupo and bolognese.

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Aug 22, 2025
@svogt0511 svogt0511 changed the title Testing with updated bolognese. Testing poodle for geoLocation support Aug 23, 2025
@svogt0511 svogt0511 requested review from a team, ashwinisukale and codycooperross October 9, 2025 16:30
@svogt0511 svogt0511 merged commit 630c740 into master Oct 17, 2025
3 checks passed
@svogt0511 svogt0511 deleted the pb88-geolocation branch October 17, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants