Fix O(n^2) performance bug in uniqArr; avoid duplicate keyF evaluations #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation called ArrayBuilder.result() inside the loop, which creates a new array copy on each iteration, resulting in O(n²) behavior. This fix tracks lastAddedKey separately to compare against the previous element's key without rebuilding the array. Also uses a while loop instead of foreach to avoid closure allocation overhead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
He-Pin
approved these changes
Dec 22, 2025
Contributor
|
@JoshRosen Thanks, I think we may need use Ai agent to do a detailed review around the current implementation before we cut 1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two performance optimizations in
uniqueArr:out.result()on every loop iteration, resulting in copying of anO(n)sized array on each loop iteration. We can avoid this by keeping a reference to the last output element.keyFevaluation for the last element of the output array; the new code callskeyFexactly once per element by maintaining alastAddedKeyvariable during the loop.Claude (Opus 4.5) spotted the O(n^2) bug and designed that part of the fix. I spotted the duplicate keyF evaluation and suggested this fix (plus the switch to a
whileloop).