Add service principal authentication support #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David <dr00b@users.noreply.github.com>
dr00b
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
Collaborator
|
Plz refer to this comment - #29 (comment) |
Author
|
Thanks @jprakash-db, I will give this a try. If it works, I'll change this PR to edit the docs with a working example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #29. Adding support for service principal usage to avoid workarounds in app code or usage of less secure developer access tokens.
I have tested this against a DBX workspace hosted on GCP. I believe
test_sp_token_refresh_allows_followup_insertis sufficent testing that the auth token is refreshed as expected, but will report back if I see anything funky as I use it.