Skip to content

oracle adapter support #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vinodsugur wants to merge 2 commits into
base: main
Choose a base branch
from
Open

oracle adapter support #94

vinodsugur wants to merge 2 commits into from

Conversation

@vinodsugur
Copy link

@vinodsugur vinodsugur commented Oct 16, 2024 •
edited
Loading

Added Oracle adapter support

Description & motivation

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered):
    • Postgres
    • BigQuery
    • Snowflake
    • Redshift
    • SQL Server
    • Databricks
    • Oracle
  • I have written tests for new macros (either as dbt schema tests in integration_tests/models, dbt data tests in integration_tests/tests or integration tests in the CI workflow)
  • I have updated the README.md (if applicable)

@vinodsugur
oracle adapter support
3539356 
Added Oracle adapter support
stumelius
stumelius requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@stumelius stumelius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR @vinodsugur, and sorry for the delay in getting to review this. Oracle support would definitely be a nice-to-have feature. The code in general looks good and I left a few comments. Can you address those? Can you also make sure that Oracle gets added to the supported adapters list in the README?

@vinodsugur
Resolved open comments
f1fc9d1 
I have resolved open queries.
vinodsugur
vinodsugur commented Nov 27, 2024
View reviewed changes
Copy link
Author

@vinodsugur vinodsugur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved open queries. Please review.

@vinodsugur
Copy link
Author

vinodsugur commented Nov 27, 2024

Thank you for opening this PR @vinodsugur, and sorry for the delay in getting to review this. Oracle support would definitely be a nice-to-have feature. The code in general looks good and I left a few comments. Can you address those? Can you also make sure that Oracle gets added to the supported adapters list in the README?

@vinodsugur
Copy link
Author

vinodsugur commented Nov 27, 2024

I have closed on all open points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stumelius stumelius stumelius requested changes

+1 more reviewer

@noelportillo noelportillo noelportillo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinodsugur @stumelius @noelportillo