Scraping from Arabic news#2016
Conversation
|
@BusinessLanguage looks good! |
|
Very nice! Do we want to use these accidents for our reports and infographics?
|
* Historic data scraping added (2015-2022)
* Historic data scraping added (2015-2022)
anyway/parsers/scrape_arabic_news.py
Outdated
There was a problem hiding this comment.
Hi, I would like us to use type hints in function parameters and variables.
anyway/parsers/scrape_arabic_news.py
Outdated
There was a problem hiding this comment.
Hi,
- In python we use lowercase and underscore for variables and function/method names.
- I prefer not to change the variable loop in the loop. It is better to use a different variable.
There was a problem hiding this comment.
Are we OK that the API key is in our code, in a public repo?
There was a problem hiding this comment.
Still working on this one..
Accidently pushed it to the PR
There was a problem hiding this comment.
Hi, the style we use for file names is lowercase with underscore between words.
ziv17
left a comment
There was a problem hiding this comment.
Hi, Well done!
See some technical comments below.
How is this code going to be incorporated in our application? I think it worth a discussion.
|
@ziv17 Thank you for your comments. Will amend those issues soon. regarding your question, incorporating the obtained data in the database will be carried out after the newsflash been translated (using Google API) and then will undergo the same process as your mainstream data. |
Next steps: