Improved _assign_attribute implementation#70
Merged
Conversation
matthinea
force-pushed
the
faster-attr-assignment
branch
from
913ea06 to
a3d8a56
Compare
Contributor
Author
|
Merging as there's no behavior change, and I'd like to see the performance implications. |
matthinea
changed the title
_assign_attribute_assign_attribute implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See this commit in Rails. My own performance testing indicates that Platform DataImport performance is impacted by the described behavior.
Solution
Borrow from the more-performant, latest
ActiveModelimplementation of_assign_attribute. I tried removing this method override entirely at first and just relying on the ActiveModel implementation directly, but it turns out we're pretty reliant upon the "fail silently" behavior achieved by therespond_to?check.