Skip to content

after_commit all the things #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrek-data-axle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

after_commit all the things #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/elastic_record/model/callbacks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ module ElasticRecord
module Model
module Callbacks
def self.included(base)
return unless base.respond_to?(:after_save) && base.respond_to?(:after_destroy)
return unless base.respond_to?(:after_commit)
Copy link
Contributor

@betesh-at-data-axle betesh-at-data-axle Mar 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic_record only supports Ruby 2.7+:

elastic_record/elastic_record.gemspec

Line 9 in 3a2de44

s.required_ruby_version = '>= 2.7'

Based on https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html, that pretty much limits it to Rail >= 6.

So if the point of this line is to ensure that we're using a version of Rails that supports after_commit (which has been around since Rails 3), we can remove it.

Otherwise, this is the same as if defined?(ActiveRecord::Base) && base < ActiveRecord::Base, which I think is a more explicit way of expressing what we're trying to achieve here.


base.class_eval do
after_create :index_to_elasticsearch
after_update :update_index_document, if: -> { respond_to?(:saved_changes?) ? saved_changes? : changed? }
after_destroy :delete_index_document
after_commit :index_to_elasticsearch, on: :create
after_commit :update_index_document, on: :update, if: -> { respond_to?(:saved_changes?) ? saved_changes? : changed? }
after_commit :delete_index_document, on: :destroy
end
end

Expand Down